feat(providers/azure): cancel pipeline if unexpected exception caught #32238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
Adaverse
reviewed
Jun 28, 2023
| parameters=self.parameters, | ||
| ) | ||
| self.run_id = vars(response)["run_id"] | ||
| context["ti"].xcom_push(key="run_id", value=self.run_id) |
There was a problem hiding this comment.
In a few execute methods of Operators, I see we return to push to xcom. Was wondering if is there any advantage of one over the other.
There was a problem hiding this comment.
if you return it from execute method it will get stored with the "return_value" key but with context["ti"].xcom_push(...) you can have a custom key name for example run_id in this case
Lee-W
force-pushed
the
check-existing-pipeline-run-for-AzureDataFactoryRunPipelineOperator
branch
from
6d536fa to
20491f7
Compare
…ryRunPipelineOperator when retry
Lee-W
changed the title
…ataFactoryRunPipelineOperator when retry" This reverts commit 20491f76812c222d9b444c6d18b749fedc84f145.
…tion failure and check whether cancel_pipline_run is called if unexpected exception occur
Lee-W
force-pushed
the
check-existing-pipeline-run-for-AzureDataFactoryRunPipelineOperator
branch
from
20491f7 to
1d89611
Compare
potiuk
approved these changes
Jun 29, 2023
69 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue to resolve
When retrying after the 1st failure, the AzureDataFactoryRunPipelineOperator creates a new pipeline run without canceling the original one. This happens when the triggerer fails unexpectedly and gets caught here.
What's changed
Clean up the previous pipeline wrong if unexpected error caught
I tried to check whether the previous run was still running. But we'll need to pass the job_id from the previous run to the current run. According to #18917, it seems we can not use xcom to achieve it, and I doubt Varaible is a good solution.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.